Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify default setting of :static to reflect the Proc #1052

Closed
wants to merge 1 commit into from

Conversation

mwpastore
Copy link
Member

The README states that :static is disabled by default in modular mode, but it is actually enabled if :public_folder is set and exists on the filesystem. This commit clarifies the README.

@stjhimy
Copy link
Contributor

stjhimy commented Dec 3, 2015

In my opinion it would look better just writing it down:

false
true if :public_folder is set

@mwpastore
Copy link
Member Author

It would be "false, true if" but point taken. I was trying to follow the example of :run (which gives an expression), but perhaps we could rephrase both?

@kgrz
Copy link
Member

kgrz commented Jan 18, 2016

"false, true if" version sounds better for documentation. @mwpastore Care to update the PR?

@kgrz
Copy link
Member

kgrz commented Jan 18, 2016

but it is actually enabled if :public_folder is set

I feel this can get a bit misleading. To clarify what I mean, only if :public_folder is set to anything other than the default one, the :static is set to true in modular apps. Otherwise, it's still "false by default"

@mwpastore
Copy link
Member Author

@kgrz Part of the problem here is that :public_folder also has a default (a directory named "public" in :root), so there's a potential here for :static to be true by default in modular apps. I'm just trying to figure out the best way to update the documentation to reflect this.

@kgrz
Copy link
Member

kgrz commented Jan 20, 2016

Ah, yes. I get what you're saying. That clarification is very useful to
remove the confusion. Do you want to update the PR with the changes
suggested by @stjhimy above (verbal vs code)?

@zzak zzak closed this in bab0355 Jan 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants