Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change CHANGES to CHANGELOG.md #1043

Merged
merged 2 commits into from
Oct 29, 2015
Merged

change CHANGES to CHANGELOG.md #1043

merged 2 commits into from
Oct 29, 2015

Conversation

Zemmiph0bia
Copy link
Contributor

My first ruby project PR 🎉

  • moved CHANGES to CHANGELOG.md
  • updated CONTRIBUTING.md doc
  • updated Rakefile to use CHANGELOG.md.

original issue:
#1042

@@ -1,6 +1,7 @@
= Upcoming Release

* Correctly handle encoded colons in routes. (Jeremy Evans)
* Rename CHANGE to Changelog.md and update Rakefile. (Eliza Sorensen)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zemmiph0bia Should probably make sure the filename's casing matches.

@TrevorBramble
Copy link
Contributor

@Zemmiph0bia Just the one quibble, then I'm 👍!

@Zemmiph0bia
Copy link
Contributor Author

@TrevorBramble that should be fixed now ^^

@kytrinyx
Copy link
Contributor

w00t :)

kytrinyx added a commit that referenced this pull request Oct 29, 2015
change CHANGES to CHANGELOG.md
@kytrinyx kytrinyx merged commit fabf8ef into sinatra:master Oct 29, 2015
@zzak
Copy link
Member

zzak commented Oct 29, 2015

LGTM

@ashleygwilliams
Copy link
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants