-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use single constant for default HTTP Accept header #784
Conversation
And add missing headers in `SimplePie_Locator::body()` Follow-up of simplepie@5d966b9 This prepares for an update of the content of the default HTTP Accept header in another PR.
]; | ||
$feed = $this->registry->create(File::class, [$value, $this->timeout, 5, null, $this->useragent, $this->force_fsockopen, $this->curl_options]); | ||
$feed = $this->registry->create(File::class, [$value, $this->timeout, 5, $headers, $this->useragent, $this->force_fsockopen, $this->curl_options]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely forgotten in 5d966b9
Otherwise, the $headers
variable was not used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks like an error to me. I am in favor of fixing it this way.
Downstream PR FreshRSS/FreshRSS#5083 |
]; | ||
$feed = $this->registry->create(File::class, [$value, $this->timeout, 5, null, $this->useragent, $this->force_fsockopen, $this->curl_options]); | ||
$feed = $this->registry->create(File::class, [$value, $this->timeout, 5, $headers, $this->useragent, $this->force_fsockopen, $this->curl_options]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks like an error to me. I am in favor of fixing it this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
Co-authored-by: Jan Tojnar <jtojnar@gmail.com>
The same string was repeated 5 times.
And add missing headers in
SimplePie_Locator::body()
Follow-up of 5d966b9
This prepares for an update of the content of the default HTTP Accept header in another PR.