Fix for Issue #327 - Purges MySql cache contents older than a configu #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd appreciate some feedback... :) |
|
a few things, you don't use $count so there's no point assigning to it. Since you don't need the return value I think exec is better than query here? And you might actually be better of using a prepared statement and binding cache_purge_time. |
|
You were totally right... binding is safer. Logic remains the same to delete old cached data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a new option to the MySql cache backend. Configured through set_cache_location():
cache_purge_time=seconds. It defaults to 2592000 (30 days). Everything older (not updated for 30 days) will be deleted before each call to save(), that is, when storing/updating content from the cache.
$feed->set_cache_location('mysql://user:pass@localhost:3306/table?prefix=sp_&cache_purge_time=2592000');
The following sql code will be run before any update.