chore(): bump required php version to ^8.0 since using code only available in php 8.0 #59

chrillep · 2023-03-09T18:47:14Z

hello thanks for a great package.

since '::class' on objects is only allowed since PHP 8.0,
and is used at

laravel-nova-csv-import/src/Http/Controllers/ImportController.php

Line 144 in 6611a93

$model_class = $resource->resource::class;

you can safely bump to 8.0

since '::class' on objects is only allowed since PHP 8.0

simonhamp

Yep this is fine. Thanks

chore: use same php require as laravel nova

dcab85f

chrillep changed the title ~~chore: use same php require as laravel nova~~ chore(): use same php require as laravel nova Mar 9, 2023

use ^8.0

096024e

since '::class' on objects is only allowed since PHP 8.0

chrillep changed the title ~~chore(): use same php require as laravel nova~~ chore(): dump required php version to ^8.0 since using code only available in php 8.0 Mar 9, 2023

chrillep changed the title ~~chore(): dump required php version to ^8.0 since using code only available in php 8.0~~ chore(): bump required php version to ^8.0 since using code only available in php 8.0 Mar 9, 2023

simonhamp approved these changes Mar 9, 2023

View reviewed changes

simonhamp merged commit 8498979 into simonhamp:main Mar 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(): bump required php version to ^8.0 since using code only available in php 8.0 #59

chore(): bump required php version to ^8.0 since using code only available in php 8.0 #59

chrillep commented Mar 9, 2023 •

edited

Loading

simonhamp left a comment

chore(): bump required php version to ^8.0 since using code only available in php 8.0 #59

chore(): bump required php version to ^8.0 since using code only available in php 8.0 #59

Conversation

chrillep commented Mar 9, 2023 • edited Loading

simonhamp left a comment

Choose a reason for hiding this comment

chrillep commented Mar 9, 2023 •

edited

Loading