add image to image vae compile demo #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strint
commented
Dec 7, 2023
strint
commented
Dec 7, 2023
| #pipe.vae = oneflow_compile(pipe.vae) | ||
| # ImageToImage has encoder and decoder, so we need to compile them seperately. | ||
| pipe.vae.encoder = oneflow_compile(pipe.vae.encoder) | ||
| pipe.vae.decoder = oneflow_compile(pipe.vae.decoder) |
There was a problem hiding this comment.
compile the encoder and decoder separately
There was a problem hiding this comment.
is there an automatic way to detect and report the cause of inappropriately compiling encoder and decoder together?
There was a problem hiding this comment.
is there an automatic way to detect and report the cause of inappropriately compiling encoder and decoder together?
Yes, we are working on it in another PR: directly compile the full vae.
strint
commented
Dec 7, 2023
strint
commented
Dec 7, 2023
|
|
||
| if args.compile_vae: | ||
| from onediff.infer_compiler import oneflow_compile | ||
| #pipe.vae = oneflow_compile(pipe.vae) |
There was a problem hiding this comment.
Related work takes my time: #394
But it's not trivial to compile the encode and decode in one graph.
lixiang007666
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance:
Run: