Show 'You' in Android theme quotes instead of contact name #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasi-signal
approved these changes
Apr 30, 2018
|
|
||
|
|
||
| const authorProfileElement = authorProfileName | ||
| ? <span className="profile-name">~{authorProfileName}</span> |
There was a problem hiding this comment.
OT: What’s the history of the tile prefix for profile names? I understand if offers some visual distinction but it always seemed a bit low-fi to me 😉
There was a problem hiding this comment.
It's to visually distinguish it from the names we pull from your contacts. The idea was to ensure that nobody could be faked out by an attacker who set their profile to be the same name as someone already in their target's contacts.
scottnonnenberg-signal
added a commit
that referenced
this pull request
May 1, 2018
Media Gallery showing all attachments in a given conversation (#2291, previous: #2236) Quotes: - Show 'You' in Android theme instead of your own contact name (#2312) - Show thumbnails for quotes of messages with video attachments (#2293) Video attachments: show first frame preview in composition area (#2293) Increase speed of migration to move attachments to disk from database (#2314) Dev: - Add comments clarifying our mechanisms for stripping EXIF info (#2313) - Move to prettierjs to format our code (#2303) - Fix break in styleguide; make filesize/Signal.Util.GoogleChrome available (#2302) - Remove duplicate entry from .gitignore (#2271)
scottnonnenberg-signal
added a commit
that referenced
this pull request
May 10, 2018
Media Gallery showing all attachments in a given conversation (#2291, previously #2236) Note: Until all attachments have been migrated to disk (as part of a background process), only a partial set of a conversation's media will show up, skewed towards the most recent messages Quotes: - Show 'You' in Android theme instead of your own contact name (#2312) - Show thumbnails for quotes of messages with video attachments (#2293) Video attachments: show first frame preview in composition area (#2293) Notification improvements - Remove all on remote read, on focus, on exit - Show multi-message notifications like '5 new messages' Increase speed of migration to move attachments to disk from database (#2314) Dev: - Add comments clarifying our mechanisms for stripping EXIF info (#2313) - Move to prettierjs to format our code (#2303) - Fix break in styleguide; make filesize/Signal.Util.GoogleChrome available (#2302) - Remove duplicate entry from .gitignore (#2271)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of pulling information from the user's contacts (which doesn't always have their own contact set), we now show 'You' for quotes referencing the current user in the android theme. This mirrors 'Replying to Yourself' or 'Replying to You' shown in the iOS theme already.
Before:
After:
