Remove Jetifier from Build #13378
Closed
Remove Jetifier from Build #13378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
materialish-progress and subsampling-scale-image-view were bringing in Android Support libraries as transitive dependencies. This required Jetifier to be run as part of the build. More recent versions of these dependencies have been released, which now use AndroidX directly. By upgrading these dependencies, Jetifier is no longer needed to build Signal.
|
Thank you so much! This has been on my wishlist for a while, glad we can finally do it :) This will go out in our 6.46 release. |
TwoLeaves
pushed a commit
to TwoLeaves/Signal-antisocial
that referenced
this pull request
Feb 7, 2024
materialish-progress and subsampling-scale-image-view were bringing in Android Support libraries as transitive dependencies. This required Jetifier to be run as part of the build. More recent versions of these dependencies have been released, which now use AndroidX directly. By upgrading these dependencies, Jetifier is no longer needed to build Signal. Resolves signalapp#13378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription
This removes Jetifier from the build.
2 out-of-date dependencies were bringing in Android Support libraries as transitive dependencies. This required Jetifier to be run. More recent versions of these libraries have been released, now directly using AndroidX equivalents. By upgrading these dependencies, Jetifier is no longer needed.
com.pnikosis:materialish-progress:1.5com.pnikosis:materialish-progress:1.7com.davemorrissey.labs:subsampling-scale-image-view:3.10.0com.davemorrissey.labs:subsampling-scale-image-view-androidx:3.10.0