Compatibility update with GNFW #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating dev branch
Update main branch
Update hierarc fork
williyamshoe
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=======================================
Coverage 99.18% 99.19%
=======================================
Files 49 49
Lines 2583 2597 +14
=======================================
+ Hits 2562 2576 +14
Misses 21 21
|
ajshajib
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Thanks a lot, @williyamshoe. I am requesting a minor variable name change for simplicity.
ajshajib
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
KinConstraintsCompositeclass so that it is compatible with Lenstronomy #650.KinConstraintsCompositenow acceptsalpha_Rs_arrayas input, or alternativelykappa_s_arrayorrho0_array.