Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Timing of deployment status and local run printouts #744

Merged
merged 6 commits into from
Apr 3, 2023
Merged

fix: Timing of deployment status and local run printouts #744

merged 6 commits into from
Apr 3, 2023

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Mar 22, 2023 •
edited
Loading

Description of change

  1. Prints the "Starting ... on localhost:8000" string in local run earlier so that is always prints before any output from the run. Didn't make sense.
  2. Wait 500ms before calling project summary after deploy. This delay fixes "Deployment has not entered running state" showing on normal deploys since the deploy now has enough time to enter Running/Crashed state.
  3. Fixed alignment of some printouts in local run.
  4. Other minor cleanup.

How Has This Been Tested (if applicable)?

Tested on local run and deploy against prod.

@jonaro00 jonaro00 force-pushed the fix/deploy-timing branch from a33f3a4 to 8d1cb8a Compare March 22, 2023 13:42
@jonaro00 jonaro00 changed the title Fix timing of local printout and deployment status fix: Timing of deployment status and local run printouts Mar 25, 2023
chesedo
chesedo reviewed Mar 28, 2023
View reviewed changes
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the touch ups @jonaro00! I just have one question 😄

cargo-shuttle/src/lib.rs Show resolved Hide resolved
cargo-shuttle/src/lib.rs Outdated Show resolved Hide resolved
@jonaro00 jonaro00 requested a review from chesedo March 29, 2023 16:58
@oddgrd oddgrd merged commit 07be36c into shuttle-hq:main Apr 3, 2023
@jonaro00 jonaro00 deleted the fix/deploy-timing branch April 3, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesedo chesedo chesedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonaro00 @chesedo @oddgrd