feat: resources endpoint #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
Looks great, I look forward to seeing it in action! One thing I am wondering, and this is a bit of a brainstorm, should we have a consistent strategy for documenting the endpoints intended to be consumed by the console (or all of them 😅)? Perhaps something like openapi down the line (with which I only have experience consuming). It may not be so clear to our console developers what this returns. 🤔
Either way looks good to me! Just something we can keep in mind as we develop the console api.
I like this suggestion. Maybe there is something that can auto-generate the openapi for us 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Prepares a resources endpoint for the upcoming console 🙊
How Has This Been Tested (if applicable)?
NA