Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: AWS RDS #180

Merged
merged 62 commits into from
Jun 20, 2022
Merged

feat: AWS RDS #180

merged 62 commits into from
Jun 20, 2022

Conversation

chesedo
Copy link
Contributor

@chesedo chesedo commented May 18, 2022 •
edited
Loading

Adds support for Postgres, Mysql and MariaDB AWS RDS

Needs #167

Breaking change

All old deploys that use the PgPool needs to add attribute configuration to explicitly ask for a shared Postgres resource as follow:

#[shuttle_service::main]
async fn rocket(#[shared::Postgres] pool: PgPool) -> Result<Rocket<Build>, shuttle_service::Error> {
    //          ^^^^^^^^^^^^^^^^^^^
    //                   |
    //                   This is the part to add

    // Business as usual here
}

@chesedo chesedo force-pushed the feat/rds branch 2 times, most recently from 49562a3 to db53405 Compare May 24, 2022 07:16
chesedo added 28 commits May 30, 2022 10:28
@chesedo
feat: simple RDS support
6baee8b
@chesedo
refactor: cleanup and prep
008b204
@chesedo
feat: Simple AWS RDS Postgres tuple
5fbff83
@chesedo
feat: MySql and MariaDB support
e743f3d
@chesedo
refactor: add engine to DB info
90d9103
@chesedo
refactor: 'master' for username
4e0adc5
@chesedo
refactor: clippy suggestions
6e20ccf
@chesedo
refactor: better debug logs
6e244c5
@chesedo
refactor: set region
366d583
@chesedo
refactor: increase tracing
9d9c2a0
@chesedo
refactor: try more timeouts
2b541dc
@chesedo
refactor: try manual profile
b6bd166
@chesedo
refactor: try manual imds provider
3ed7c8b
@chesedo
refactor: try manual client
c7444f3
@chesedo
refactor: set read timeout
268dcbb
@chesedo
refactor: try endpoint override
17c61fa
@chesedo
refactor: trying aws update
966c233
@chesedo
refactor: finally found it
c206d5a
@chesedo
refactor: remove region
310f833
@chesedo
bug: increase hop limit
ed6ee42
@chesedo
feat: add policy to handle RDS
589487f
@chesedo
refactor: try subnet group
537a18c
@chesedo
refactor: more permission fixes
25d8ada
@chesedo
feat: add rds subnet
0023a18
@chesedo
refactor: cleanup
f26519a
@chesedo
feat: switch to attribute annotation
1aab7a4
@chesedo
refactor: move to aws::rds
e21e005
@chesedo
feat: aws::rds example
ff6cbef
@chesedo chesedo marked this pull request as ready for review May 30, 2022 13:41
@chesedo chesedo requested a review from brokad May 30, 2022 13:42
@chesedo chesedo requested a review from bmoxb June 7, 2022 10:14
bmoxb
bmoxb approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@bmoxb bmoxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks cool to me, the #[shared::Postgres], etc. proc-macro annotations are very funky :)

examples/tide/postgres/src/lib.rs Outdated Show resolved Hide resolved
examples/tide/postgres/src/lib.rs Outdated Show resolved Hide resolved
chesedo and others added 2 commits June 16, 2022 16:38
@chesedo
bug: PG timeout
fbb1588
@chesedo @bmoxb
Apply suggestions from code review
b54ae81 
Co-authored-by: Max <42641081+bmoxb@users.noreply.github.com>
@chesedo chesedo merged commit 6a11b03 into main Jun 20, 2022
@chesedo chesedo deleted the feat/rds branch June 20, 2022 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmoxb bmoxb bmoxb approved these changes

@brokad brokad Awaiting requested review from brokad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chesedo @bmoxb