Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failing cargo shuttle deploy returns successful exit code #166

Merged
merged 6 commits into from
Jul 5, 2022
Merged

fix: failing cargo shuttle deploy returns successful exit code #166

merged 6 commits into from
Jul 5, 2022

Conversation

bmoxb
Copy link
Contributor

@bmoxb bmoxb commented May 10, 2022 •
edited by chesedo
Loading

cargo shuttle deploy and cargo shuttle status will now return shell error/failure code (i.e. non-zero value) should the deployment in question be in the 'error' state.

Closes #138

@bmoxb bmoxb force-pushed the fix/shell-error-code-deployment-failure branch from b9a8d3d to d05198a Compare May 10, 2022 01:27
chesedo
chesedo reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this @bmoxb! I'm wondering how we can make this cleaner 🤔

cargo-shuttle/src/main.rs Outdated Show resolved Hide resolved
@bmoxb bmoxb force-pushed the fix/shell-error-code-deployment-failure branch from 1035f63 to 9ae6ea3 Compare June 30, 2022 22:13
@bmoxb bmoxb requested a review from chesedo June 30, 2022 22:16
@chesedo chesedo merged commit eea2d8f into main Jul 5, 2022
@chesedo chesedo deleted the fix/shell-error-code-deployment-failure branch July 5, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesedo chesedo chesedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failing cargo shuttle deploy returns successful exit code
2 participants
@bmoxb @chesedo