Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Use manual arg parsing in runtime instead of clap #819

Closed
1 task done
jonaro00 opened this issue Apr 26, 2023 · 4 comments · Fixed by #822
Closed
1 task done

[Improvement]: Use manual arg parsing in runtime instead of clap #819

jonaro00 opened this issue Apr 26, 2023 · 4 comments · Fixed by #822
Labels
💎 Bounty 💰 Rewarded T-Improvement Improvement or addition to existing features

Comments

@jonaro00
Copy link
Member

Describe the feature

The args used are only used internally, so having the user-friendly clap parser adds unnecessary overhead.

Bonus: Also add a message when running without any args to suggest running cargo shuttle run instead. (this happens if user runs cargo run)

Suggestion or Example of how the feature would be used

No response

Duplicate declaration

  • I have searched the issues and this feature has not been requested before.
@oddgrd oddgrd added the T-Improvement Improvement or addition to existing features label Apr 26, 2023
@oddgrd
Copy link
Contributor

oddgrd commented Apr 26, 2023

Thanks @jonaro00, good idea! In a PR for this we should also make sure that the places where the runtime CLI is called is updated to work with these changes, e.g. cargo shuttle run.

/bounty 50

@algora-pbc
Copy link

algora-pbc bot commented Apr 26, 2023

💎 $50.00 bounty created by oddgrd
👉 To claim this bounty, submit a pull request that includes the text /claim #819 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to shuttle-hq/shuttle!

@kierendavies kierendavies mentioned this issue Apr 26, 2023
Merged
@algora-pbc
Copy link

algora-pbc bot commented Apr 26, 2023

💡 kierendavies submitted a pull request that claims the bounty. You can visit your org dashboard to reward.

@algora-pbc
Copy link

algora-pbc bot commented May 15, 2023

🎉🎈 @kierendavies has been awarded $50.00! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty 💰 Rewarded T-Improvement Improvement or addition to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(runtime): Remove dependency on clap kierendavies/shuttle
2 participants
@oddgrd @jonaro00