Feat: unbox the ClaimService and Scoped futures #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Yes, the difference is quite small, so small that I would need to do more tests to verify its significance. One could argue that this is a bit overkill, but I learned a lot about how to do this and I think we can see more gains in layers like ShuttleAuthLayer. So I'm happy whether we merge this or not. 👍 |
|
Nah, I would definitely want to convert all of them eventually. At a scale of thousands this won't be an overkill as these are called for almost every request |
|
That's good because I had fun converting them 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can unbox the future type in tower layers if we implement future ourselves. For how I landed on the implementation for ClaimService, see: https://github.com/tower-rs/tower/blob/master/guides/building-a-middleware-from-scratch.md
For what inspired the enum solution for the Scoped future, see: https://github.com/tower-rs/tower/blob/master/tower/src/load_shed/future.rs#L13-L63