Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clap v3 for command line argument parsing #248

Closed
Xavientois opened this issue Jul 9, 2022 · 1 comment
Closed

Use clap v3 for command line argument parsing #248

Xavientois opened this issue Jul 9, 2022 · 1 comment

Comments

@Xavientois
Copy link
Contributor

Currently, clap v3 is used in the provisioner crate:

shuttle/provisioner/Cargo.toml

Line 13 in 9d28924

clap = { version = "3.1.18", features = ["derive", "env"] }
while structopt is used in api and cargo-shuttle:

shuttle/api/Cargo.toml

Line 28 in 9d28924

structopt = "0.3.26"

shuttle/cargo-shuttle/Cargo.toml

Line 30 in a21c456

structopt = "0.3.26"

Now that all of structopt's features are in clap v3 and structopt is in maintenance mode, it might make sense to migrate all crates in the workspace to use clap v3 to allow access to new features and a uniform way to define CLIs across Shuttle crates.

For this and other CLI dependencies, it might make sense to add them as workspace dependencies to allow all crates in the workspace to reference the shared version.
@Xavientois
Copy link
Contributor Author

I am down to work on this if no one else wants to claim it.

This was referenced Jul 12, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Xavientois