Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codegen): use full path for std types #1702

Merged
merged 10 commits into from
Mar 27, 2024
Merged

fix(codegen): use full path for std types #1702

merged 10 commits into from
Mar 27, 2024

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Mar 25, 2024 •
edited
Loading

Description of change

  • Fixes compilation error if Result or Vec is being shadowed in the user namespace.
  • Remove old stuff + update docs, names, comments, tests.

How has this been tested? (if applicable)

CI

oddgrd
oddgrd approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonaro00 jonaro00 merged commit 71e240f into shuttle-hq:main Mar 27, 2024
28 checks passed
@jonaro00 jonaro00 deleted the macro-absolute-paths branch March 27, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddgrd oddgrd oddgrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonaro00 @oddgrd