fix: cargo audit failures #1475
Conversation
|
One quick question before approving: will the fix here RustCrypto/RSA#394 need to be followed by PR(s) in |
If a fix was released for |
{{ message }}
Merged
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianbarbu
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR removes updates our dependencies using
cargo update, this resolves one of the cargo warnings, with pertains to the yanked wasm-bindegen version 0.2.88.The other warning is for https://rustsec.org/advisories/RUSTSEC-2023-0071.html, which is pulled in by
sqlx/mysql, which we don't use, but it is pulled in due to a bug in cargo, see launchbadge/sqlx#2911 and rust-lang/cargo#10801. We should be safe to ignore the warning forrsa. A fix for the vulnerability is also underway, but we'd need to wait for it to be finished and pulled intosqlx. I am following thersaPR, so I will be notified when it is merged, we can then remove this ignore (whensqlxupdates theirrsadependency).How has this been tested? (if applicable)
CI.