Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failing cargo shuttle deploy returns successful exit code #138

Closed
alsuren opened this issue Apr 15, 2022 · 0 comments · Fixed by #166
Closed

failing cargo shuttle deploy returns successful exit code #138

alsuren opened this issue Apr 15, 2022 · 0 comments · Fixed by #166
Labels
Contribution Wanted The community is welcome to collaborate on this issue T-Bug Something isn't working

Comments

@alsuren
Copy link
Contributor

alsuren commented Apr 15, 2022

if I forget to do the lib.crate-type = ["cdylib"] dance, cargo shuttle deploy gives me:

   Compiling reqwest v0.11.9
   Compiling dancelist v0.1.0 (/opt/unveil/crates/dancelist)
    Finished dev [unoptimized + debuginfo] target(s) in 1m 37s

        Project:            dancelist
        Deployment Id:      d3a0e264-f785-42d5-bf85-0d39aba5fb36
        Deployment Status:  ERROR: "a cdylib was not created"
        Host:               dancelist.shuttleapp.rs
        Created At:         2022-04-15 06:38:17.692974962 UTC

but cargo-shuttle's exit code is still "success" ($? == 0) in this case :-( . This means that bash's && and || chains do the wrong thing. This also means you can't build useful CI pipelines, etc.

Originally posted by @alsuren in qwandor/dancelist#2 (comment)
@christos-h christos-h added T-Bug Something isn't working Contribution Wanted The community is welcome to collaborate on this issue labels Apr 15, 2022
@bmoxb bmoxb mentioned this issue May 10, 2022
Merged
@kaleidawave kaleidawave mentioned this issue May 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Contribution Wanted The community is welcome to collaborate on this issue T-Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: failing cargo shuttle deploy returns successful exit code shuttle-hq/shuttle
2 participants
@alsuren @christos-h