Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: truncate log item strings #1227

Merged
merged 5 commits into from
Sep 12, 2023
Merged

fix: truncate log item strings #1227

merged 5 commits into from
Sep 12, 2023

Conversation

jonaro00
Copy link
Member

Description of change

How has this been tested? (if applicable)

chesedo
chesedo approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

oddgrd
oddgrd reviewed Sep 12, 2023
View reviewed changes
common/src/log.rs Outdated Show resolved Hide resolved
oddgrd
oddgrd reviewed Sep 12, 2023
View reviewed changes
common/src/log.rs Outdated Show resolved Hide resolved
@jonaro00 jonaro00 changed the title fix: log length truncating fix: truncate log item strings Sep 12, 2023
@jonaro00 jonaro00 merged commit 30c0bde into shuttle-hq:feat/shuttle-logger-service Sep 12, 2023
@jonaro00 jonaro00 deleted the fix/log-length-truncating branch September 12, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddgrd oddgrd oddgrd left review comments

@iulianbarbu iulianbarbu iulianbarbu left review comments

@orhun orhun orhun approved these changes

@chesedo chesedo chesedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonaro00 @chesedo @iulianbarbu @orhun @oddgrd