Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suggestion to 'project not ready' error message #1169

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Add suggestion to 'project not ready' error message #1169

merged 2 commits into from
Aug 22, 2023

Conversation

beyarkay
Copy link
Contributor

Description of change

Just a quick error message PR based on this discord message from @jonaro00 which expands on the project not ready error.

This adds the help text Try run `cargo shuttle project restart`. if the project is not ready:

Error: 503 Service Unavailable
message: project not ready. Try run `cargo shuttle project restart`.

@beyarkay beyarkay changed the title Add suggestion to 'project not ready' error msg Add suggestion to 'project not ready' error message Aug 22, 2023
@beyarkay
Copy link
Contributor Author

CI is failing with a TCP connection error:

running 1 test
thread 'manage_resources' panicked at 'called `Result::unwrap()` on an `Err` value: 
tonic::transport::Error(Transport, hyper::Error(Connect, ConnectError("tcp connect error", Os { 
code: 111, kind: ConnectionRefused, message: "Connection refused" })))', 
resource-recorder/tests/integration_tests.rs:43:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test manage_resources ... FAILED

Although the main CI build is also failing at the moment so I'll wait for that to clear before I try to problem solve.

jonaro00
jonaro00 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@jonaro00 jonaro00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry about the error. CI do be failing sometimes.
Thanks for the change. Just a small nit.

common/src/models/error.rs Outdated Show resolved Hide resolved
@beyarkay @jonaro00
Update common/src/models/error.rs
de40aa3 
Co-authored-by: jonaro00 <54029719+jonaro00@users.noreply.github.com>
oddgrd
oddgrd approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@oddgrd oddgrd merged commit 2c86a52 into shuttle-hq:main Aug 22, 2023
@beyarkay beyarkay deleted the project-not-ready-msg branch August 22, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaro00 jonaro00 jonaro00 approved these changes

@oddgrd oddgrd oddgrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beyarkay @oddgrd @jonaro00