chore(resources): rename service-info to metadata #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't rename the internal types as requested @jonaro00 |
jonaro00
approved these changes
Aug 21, 2023
oddgrd
reviewed
Aug 21, 2023
jonaro00
reviewed
Aug 21, 2023
resources/metadata/README.md
Outdated
| ```rust | ||
| #[shuttle_runtime::main] | ||
| async fn app( | ||
| #[shuttle_metadata::ShuttleServiceInfo] service_info: shuttle_metadata::ServiceInfo, |
There was a problem hiding this comment.
We can also rename the structs
|
We have a regression in |
|
@iulianbarbu addressed in 566b50a |
chesedo
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Rename
shuttle-service-infotoshuttle-metadatasince it will contain more information than only the service in the future.How has this been tested? (if applicable)
Na.