Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add idle timeout warning after a deploy #1116

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

christos-h
Copy link
Member

Description of change

Lot's of users get confused when their project goes to sleep after exceeding the idle timeout limit without any activity.

This should hopefully help them.

How has this been tested? (if applicable)

Not yet, hence the draft.

@christos-h christos-h marked this pull request as ready for review July 30, 2023 17:09
Copy link
Contributor

@iulianbarbu iulianbarbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @christos-h ! I am also thinking about displaying the idle_minutes info in response to project_create which gets called for cargo shuttle project start, which accounts for the idle_minutes behind the scenes even if not set.

As for testing, I think we would need to add an e2e test where we make some kind of CLI screenshot test against the idle_minutes. I don't think we have the infra for this yet, so it would be something we'll need to add in this PR. Also e2e tests run only on the production branch, but I think we can comment the .cricleci filter in order to run them as part of the CI for this PR too.

However, it might be a bit of a stretch as for the scope of this PR to include such level of testing. Some manual tests and screenshots with the output could be of help too, but let us know what you think.

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @christos-h! I'm thinking we should also add the warning to "project_create", since that's when it's set. Arguably we should only have it there, but if users miss that then the reminder when deploying might be useful. Edit: I see Iulian already suggested this 😄

I should be able to implement these changes and resolve the conflicts this week if you don't have time, by the way!

@oddgrd oddgrd merged commit 28d1a7a into main Aug 23, 2023
@oddgrd oddgrd deleted the feat/show-idle-minutes-on-deploy branch August 23, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants