Added the missing support for creating custom resources #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianbarbu
force-pushed
the
feature/eng-700-resources-missing-custom-resource-enum-variant
branch
from
0db2eb2 to
e4199f6
Compare
chesedo
reviewed
Jul 17, 2023
iulianbarbu
force-pushed
the
feature/eng-700-resources-missing-custom-resource-enum-variant
branch
from
e4199f6 to
a22480c
Compare
iulianbarbu
force-pushed
the
feature/eng-700-resources-missing-custom-resource-enum-variant
branch
from
74f1f28 to
2826be1
Compare
iulianbarbu
added a commit
that referenced
this pull request
Jul 18, 2023
* common: added custom resource type enum variant * deployer: add support for custom resources * deployer: fix FromStr to resource::Type * resource-recorder: add custom resource type * docs: adjust docs to refer to custom-resource examples * P review: remove comment until changing persist info is requested
AlphaKeks
pushed a commit
to AlphaKeks/shuttle
that referenced
this pull request
Jul 21, 2023
) * common: added custom resource type enum variant * deployer: add support for custom resources * deployer: fix FromStr to resource::Type * resource-recorder: add custom resource type * docs: adjust docs to refer to custom-resource examples * P review: remove comment until changing persist info is requested
jonaro00
deleted the
feature/eng-700-resources-missing-custom-resource-enum-variant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The
shuttle-common::resource::Typemisses theType::Customvariant that gets to be used when provisioning custom resources according to theservicecrate docs.How has this been tested? (if applicable)
Locally against shuttle-hq/shuttle-examples#73 and on unstable.