Fixed Permalink: repeated params whith useAnchor=false #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Permalink with useAnchor=false uses ? instead of # as delimiter between base URL and parameters. But the parameters are added twice ore more if Permalink is clicked again.
The reason is: space characters of layer names get coded to %20 in a permalink-URL. So the names do not match any more and the first (default?) layer is choosen. Same happens for other special characters. Fixed it with decodeURI().
|
Sorry, the second commit belongs to another issue (#57) Looks like I'm still not able to create a pull request with only one commit. |
|
Thanks for the fixes @buche :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permalink with useAnchor=false uses ? instead of # as delimiter between
base URL and parameters. But the parameters are added twice ore more if
Permalink is clicked again.
Fixes #55
Fixes #73