Add a timeout when waiting for RX #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting some keys, we sometimes expect receive a command from the host (e.g. caps lock). Some host send commands to set LED status during set _or_ break. For example, when it comes to turn on a LED host commands are sent just after the key is pushed and nothing when released. The second time the key is pushed no command are sent but when the key is released commands are sent. Corrent firmware does not handle this and always expect a command from the host after sending some set commands. In this situation firmware is stuck waiting for some commands that won't come. This patch adds a timeout when waiting for commands from host. If the command is not received after RX_TIMEOUT (which is expressed as timer tick) its not waited anymore. Signed-off-by: Franck Jullien <franck.jullien@odyssee-systemes.fr>
|
May be not the bast way to fix it but at least it's a solution. |
|
Capture of a HOST command just after caps set: Capture of a HOST command just after caps break: |
|
Cool we can upload directly here ! After set:
After break:
|
|
Thank you very much 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting some keys, we sometimes expect receive a command from the
host (e.g. caps lock). Some host send commands to set LED status during
set or break.
For example, when it comes to turn on a LED host commands are sent just
after the key is pushed and nothing when released. The second time the key
is pushed no command are sent but when the key is released commands are
sent.
Corrent firmware does not handle this and always expect a command from
the host after sending some set commands. In this situation firmware is
stuck waiting for some commands that won't come.
This patch adds a timeout when waiting for commands from host. If the
command is not received after RX_TIMEOUT (which is expressed as timer
tick) its not waited anymore.
Signed-off-by: Franck Jullien franck.jullien@odyssee-systemes.fr