Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove closed filter groups from DOM #2741

Merged
merged 2 commits into from
Aug 30, 2023
Merged

remove closed filter groups from DOM #2741

merged 2 commits into from
Aug 30, 2023

Conversation

tvikito
Copy link
Contributor

@tvikito tvikito commented Aug 22, 2023 •
edited by github-actions bot
Loading

  • on projects usually they have closed filters, because of that it is not necessary to include them in the DOM
  • this helps with smaller DOM
Q A
Description, reason for the PR On projects usually they have closed filters, because of that it is not necessary to include them in the DOM. This helps with smaller DOM.
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@tvikito tvikito force-pushed the tv-FW-1676-remove-closed-filter-groups-from-DOM branch from d5e4ba3 to 86ffd88 Compare August 24, 2023 05:53
tvikito added 2 commits August 30, 2023 08:41
@tvikito
remove closed filter groups from DOM
53d5819 
- on projects usually they have closed filters, because of that it is not necessary to include them in the DOM
- this helps with smaller DOM
@tvikito
fixup! remove closed filter groups from DOM
3c5145a 
- on projects usually they have closed filters, because of that it is not necessary to include them in the DOM
- this helps with smaller DOM
@tvikito tvikito force-pushed the tv-FW-1676-remove-closed-filter-groups-from-DOM branch from 86ffd88 to 3c5145a Compare August 30, 2023 06:41
@tvikito tvikito merged commit 0c46953 into 13.0 Aug 30, 2023
@tvikito tvikito deleted the tv-FW-1676-remove-closed-filter-groups-from-DOM branch August 30, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebaholesz sebaholesz sebaholesz approved these changes

@pk16011990 pk16011990 pk16011990 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvikito @pk16011990 @sebaholesz