Cache image config #2125
Open
Cache image config #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
henzigo
commented
Nov 16, 2020
henzigo
commented
| Q | A |
|---|---|
| Description, reason for the PR | Image config is loading from file and parsed on every request. This PR just micro-optimized it and saves parsed image config into cache. Parsing took about 2ms on every request. Now it takes only 0.2ms. I used Symfony magic to get the correct cache pool |
| New feature | No |
| BC breaks | No |
| Fixes issues | ... |
| Have you read and signed our License Agreement for contributions? | Yes |
henzigo
force-pushed
the
jg-cache-image-config
branch
from
50e4ea5 to
ea2072b
Compare
henzigo
force-pushed
the
jg-cache-image-config
branch
from
ea2072b to
9a1c816
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.