-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is the php-psr extension installed by default (or by mistake) #799
Comments
Guess we submitted around same time - yeah I found it was added about an hour ago, with same stack as you. See here for add of -psr: shivammathur/php-ubuntu@83d1155 |
Confirmed, tests running within the last hour are mass failing due to a conflict with the Symfony
|
I think this probably breaking a lot of CI builds right now 😬 Impacting our builds because of the
|
I can confirm here from Drupal unit test builds as well.
|
Same here; Laravel 10 with PHP 8.2 failing...
|
Confirming that adding - name: Set PHP version
uses: shivammathur/setup-php@v2
with:
php-version: '8.2'
extensions: :php-psr <-- this line here
tools: cs2pr
coverage: none |
See shivammathur/setup-php#799 (comment) Can be reverted after shivammathur/php-ubuntu#3 is merged
If you have
|
See shivammathur/setup-php#799 (comment) Can be reverted after shivammathur/php-ubuntu#3 is merged
@jhoff you just saved us a bunch of time. Solution worked for me. Thanks for posting! |
Confirmed it broke our CI too |
Broken on our builds as well, workaround works for emergencies, but a fix that avoids us having to touch every single build file across projects would be ideal. |
It happened to me too and it broke all of our builds. I couldn't solve it with the suggestions above.
Edit: In fact, the suggestions above corrected the problem. |
Broke our CI as well |
This comment was marked as resolved.
This comment was marked as resolved.
I don't think it's helpful to anyone who has subscribed to this issue to keep seeing messages from people saying how much this broke their CI. This got enough visibility already and I'm sure it'll get a fix in a reasonable amount of time after the 0$ we pay for it. Let's give maintainer(s) some time. |
My bad, adding |
Agreed. Initially it's useful to know that an issue is not an isolated event, but it quickly hits a point of diminishing returns. A rollback PR (shivammathur/php-ubuntu#3) is made and is awaiting review from the maintainer, hopefully it is merged soon. Until then, we have a patch that works for now. |
It has been reverted. Apologies for this, The change was a bug fix for #796, but I guess I created a bigger issue. |
@shivammathur thanks for reverting and maintaining the package! It's a thankless job but makes a whole lot of peoples lives way easier and much appreciated. |
Thank you for resolving this so quickly! Would it be safe to assume that we won't be seeing any re-introduction of the PECL PSR extension anytime? IJust want to know for confidence going forward. |
@davereid Yes, no new extensions that are enabled by default will be added to the cache moving forward. |
Describe the bug
Recently we have bumped requirements for a project and it has started to use Symfony 7.x, more exactly the
Cache
component. And, while phplint is passing perfectly with PHP 7.x, for any run with PHP >= 8.0, we get the following error:Example run: https://github.com/stronk7/moodle-cs/actions/runs/7118709260
Then, looking to the list of installed extensions (wiki), I cannot see the
php-psr
extension there.But, if I disable it in the workflow (workaround) using
extensions: :php-psr
, then the tests pass ok.Example run: https://github.com/stronk7/moodle-cs/actions/runs/7118979626
So, apart from the apparent incompatibility between Symfony Cache 7.x and the PSR extension... and why we are (or not) linting the vendor directory... this issue is more about to clarify if the extension is correctly installed (and should be listed in the docs). Or if it's installed "by mistake", and it shouldn't.
Version
v1
orv2
.v2
v1
Runners
Operating systems
ubuntu-latest (22.04)
PHP versions
8.0 to 8.2 (probably also 8.3)
To Reproduce
Install Symfony Cache 7.x and try PHP-linting.
Get the linting problem detailed in the description.
Expected behavior
Linting should end ok
Screenshots/Logs
Additional context
Are you willing to submit a PR?
I'm afraid, I don't know enough :-)
The text was updated successfully, but these errors were encountered: