Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows #4

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Support Windows #4

merged 3 commits into from
Dec 3, 2024

Conversation

shinshin86
Copy link
Owner

@shinshin86 shinshin86 commented Dec 2, 2024

Summary of Changes

  • Support Windows

Note

This update includes changes to both the README and the source code to clarify and handle platform-specific behavior for audio file deletion:

  1. Source Code Updates:

    • Modified the GenerateSpeech function to ensure .wav files are not automatically deleted on Windows, regardless of the presence of options like -silent or -o. This change ensures compatibility with how Windows handles file operations during playback.
  2. README Updates:

    • Added a new section titled Handling Audio Files: Platform Differences to explain the differences in audio file behavior between macOS and Windows.
      • On macOS, temporary .wav files are automatically deleted unless preserved via options like -silent, -o, or -d.
      • On Windows, .wav files are not automatically deleted to prevent issues caused by platform-specific file handling behavior.

These changes aim to improve clarity for users and ensure consistent behavior across platforms.

issue

#1

@shinshin86 shinshin86 merged commit 02c929e into main Dec 3, 2024
@shinshin86 shinshin86 deleted the support-windows branch December 3, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant