Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add additional error message check for archive.org downtime #2339

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: add additional error message check for archive.org downtime #2339

merged 2 commits into from
Nov 11, 2024

Conversation

bytexenon
Copy link
Contributor

@bytexenon bytexenon commented Oct 20, 2024 •
edited
Loading

This pull request fixes the false positive issue with archive.org when it's down and returns a 503 status code. I added a check for the "Other Internet Archive services are temporarily offline" string in the data.json to catch it when the site is down.

Let me know if any further modifications are needed.

Closes #2338

@bytexenon
Copy link
Contributor Author

Actually, I think it would be a better idea to use the string "Internet Archive services are temporarily offline" instead of "Other Internet Archive services are temporarily offline." As they sometimes display an alternative version of that page without the word "Other," as shown in this screenshot.

@ppfeister
Copy link
Member

Thanks for being patient --- things can get quite busy sometimes

It doesn't seem that this is a problem anymore with how they've re-launched things. Can you confirm on your end? We may need to tweak archive[.]org once it gets fully back up to speed, but it seems fine at least right now.

@bytexenon
Copy link
Contributor Author

Thanks for being patient --- things can get quite busy sometimes

It doesn't seem that this is a problem anymore with how they've re-launched things. Can you confirm on your end? We may need to tweak archive[.]org once it gets fully back up to speed, but it seems fine at least right now.

Thanks for reviewing

It works for me as well, I just think it wouldn't hurt to add that additional check in case it goes down again

@ppfeister ppfeister added the false positive A site is responding with false positives label Nov 11, 2024
ppfeister
ppfeister approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@ppfeister ppfeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't oppose the idea. LGTM!

@ppfeister ppfeister merged commit cf393b8 into sherlock-project:master Nov 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppfeister ppfeister ppfeister approved these changes

Assignees
No one assigned
Labels
false positive A site is responding with false positives
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive for: archive.org
2 participants
@bytexenon @ppfeister