feat: add 21 sites #1141
Merged
feat: add 21 sites #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just rebased with master to resolve merge conflicts. |
sdushantha
approved these changes
Oct 27, 2021
|
Thank you @SethFalco for making a detailed PR. I also really appreciate you adding regex checking and as well as doing running the tests :) |
|
Seems like there is an error in the data.json after you made the changes which caused the test to fail. It also prevents us from running Sherlock properly because of this error. I'll take a look at it later. |
|
Ahh, sorry. I should've rerun the tests after rebasing probably. ^-^' |
|
Just checking, looks like you haven't checked this out yet. |
|
@SethFalco Sorry about that, Ive been a little busy. It would be greatly appreciated if you could redo the PR :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Sites
Adds 21 sites to
data.json.I've tested each site manually, and run
python3 -m unittest tests.all --verbose.Minor Formatting
Around line 1,315 there are some minor whitespace changes which was automatically performed by my editor. I left it in there since it's just to make indentation consistent.
Related
This is an adaptation of a pull request I made to a similar project.