Support input of hex, octal, and binary numbers #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triallax
force-pushed
the
support-n-base-digits
branch
from
504f6d3 to
b3d6a2d
Compare
triallax
commented
Sep 20, 2022
src/Insect/Parser.purs
Outdated
Comment on lines
125
to
129
| numberPrefix /\ digit' /\ expSymbol ← | ||
| option ("" /\ digit /\ "e") $ char '0' | ||
| *> ((char 'x' <|> char 'X') $> ("0x" /\ hexDigit /\ "p") | ||
| <|> (char 'o' <|> char 'O') $> ("0o" /\ octDigit /\ "p") | ||
| <|> (char 'b' <|> char 'B') $> ("0b" /\ (oneOf ['0', '1'] <?> "binary digit") /\ "p")) |
There was a problem hiding this comment.
kill me, what have I done
triallax
force-pushed
the
support-n-base-digits
branch
from
b3d6a2d to
2ce4688
Compare
I think it's perfectly fine as long as we add enough tests to make sure that everything is alright. Having a good test coverage also allows us to refactor with confidence later, if needed. |
Good point, I will add comprehensive tests. |
triallax
force-pushed
the
support-n-base-digits
branch
from
2ce4688 to
9b83aa0
Compare
triallax
commented
Oct 7, 2022
triallax
force-pushed
the
support-n-base-digits
branch
2 times, most recently
from
1ddd7d6 to
8f73b02
Compare
triallax
commented
Oct 11, 2022
sharkdp
reviewed
Oct 13, 2022
Comment on lines
+188
to
+195
| shouldFail "0xG" | ||
| shouldFail "0oG" | ||
| shouldFail "0oA" | ||
| shouldFail "0b2" | ||
| shouldFail "0be" | ||
| shouldFail "0x1p+" | ||
| shouldFail "0x1p-" | ||
| shouldFail "0x5.." |
sharkdp
approved these changes
Oct 13, 2022
triallax
force-pushed
the
support-n-base-digits
branch
from
8f73b02 to
6753533
Compare
triallax
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245.
I'm really, really ashamed of the terrible way I implemented this, but I honestly could not think of a way to do it that wouldn't be nearly as bad. Suggestions for alternate implementations or ways to improve the existing one are very welcome.
TODO: