OnlineConfigResolver: add User-Agent #2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
database64128
approved these changes
Oct 9, 2020
Stzx
approved these changes
Oct 10, 2020
DuckSoft
approved these changes
Oct 11, 2020
There was a problem hiding this comment.
This is very appropriate for now. Maybe in the future we could make OnlineConfig User-Agent user-editable as well. LGTM.
some other thoughts: when you declare you are 'Shadowsocks-Windows' in User-Agent, this means that you shouldn't pass this packet directly in censored channels, for example, passing it through plain HTTP. Some restrictions might be required.
Signed-off-by: Beta Soft <betaxab@gmail.com>
- For OnlineConfigResolver and GeositeUpdater
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Beta Soft betaxab@gmail.com
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Compiled the code with Visual Studio
Require translation update
Require document update (readme.md, wikipage, etc)
What is the purpose of your pull request?
Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.
User-Agent should be added to
httpClientto get online configuration.Use the shadowsocks-windows owns name
ShadowsocksWindows/{UpdateChecker.Version}instand of Web Browser default UA should be better, help online configuration API determine the client type.