Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.1.7 删除按钮有严重的问题 / Delete button issue #2458

Closed
imba-tjd opened this issue Jul 14, 2019 · 3 comments
Closed

4.1.7 删除按钮有严重的问题 / Delete button issue #2458

imba-tjd opened this issue Jul 14, 2019 · 3 comments
Labels
bug

Comments

@imba-tjd
Copy link
Contributor

imba-tjd commented Jul 14, 2019 •
edited
Loading

Shadowsocks version / 影梭版本

4.1.7

现在的效果是点删除，会删掉选中的下面的那个，并且跳到最后一项。

UpdateIndexToEnd();前一行还是正常的，执行完这个函数后没有的就是选中的下面一项了。

应该是 https://github.com/shadowsocks/shadowsocks-windows/pull/2410/files?file-filters%5B%5D=.cs&file-filters%5B%5D=.yml#diff-411c02bb9a33cb67be83f9fd7aa03dcc 引入的。
@chenshaoju
Copy link
Collaborator

chenshaoju commented Jul 14, 2019 •
edited
Loading

Confirmed @celeron533 @Stzx

@chenshaoju chenshaoju added the bug label Jul 14, 2019
@Stzx
Copy link
Collaborator

Stzx commented Jul 14, 2019

你好，看起来是我疏忽造成的这个低级错误，非常抱歉。

😰

@celeron533
Copy link
Contributor

Will release this fix ASAP.

celeron533 pushed a commit that referenced this issue Jul 14, 2019
@Stzx @celeron533
Switch configuration enable button (#2460)
12ffdcc 
Fix shadowsocks/shadowsocks-windows/#2458
celeron533 pushed a commit to celeron533/shadowsocks-windows that referenced this issue Jul 14, 2019
@Stzx @celeron533
Switch configuration enable button (shadowsocks#2460)
ecd59c8 
Fix shadowsocks/shadowsocks-windows/shadowsocks#2458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chenshaoju @celeron533 @Stzx @imba-tjd