Feat: auto toggle night mode #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasKiers
force-pushed
the
feat/auto-toggle-night_mode
branch
from
45f9879 to
2189c42
Compare
Added logic to automatically toggle nightmode when dimming the device to 100/0 percent twice in a row within 5 seconds. This is usefull when controlling the device from your mobile phone (using the new app) so you can toggle night_mode without executing a flow.
BasKiers
force-pushed
the
feat/auto-toggle-night_mode
branch
from
2189c42 to
ceee661
Compare
jghaanstra
approved these changes
Jun 30, 2018
There was a problem hiding this comment.
Interesting, I'm approving it but can this be tested using the current desktop interface? I own a ceiling4 which also has night_mode (I'll add that capability myself) and I'd like to see how it works.
And something else, should you not use .. && typeof opts.duration === undefined) to avoid a ReferenceError?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #41
Added logic to automatically toggle nightmode when dimming the device to 100/0 percent twice in a row within 5 seconds. This is usefull when controlling the device from your mobile phone (using the new app) so you can toggle night_mode without executing a flow.