Make Servo compatible with Stylo with prefers-color-scheme support
#34423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
added
the
A-layout/2020
nicoburns
changed the title
prefers-color-scheme support
Loirooriol
approved these changes
Nov 29, 2024
nicoburns
force-pushed
the
min-prefers-color-scheme
branch
from
be08a87 to
d4329ee
Compare
3 tasks
Signed-off-by: Nico Burns <nico@nicoburns.com> Update imports to work with deduped version of stylo PR Signed-off-by: Nico Burns <nico@nicoburns.com> Switch back to stylo main branch Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns
force-pushed
the
min-prefers-color-scheme
branch
from
d4329ee to
059dbd4
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Signed-off-by: Nico Burns <nico@nicoburns.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Servo compatible with
prefers-color-schemestylo#93And is a first-step towards
prefers-color-schemesupport in Servo. Actually allowing the embedder to set the preferred color scheme (and using this capability inservoshell) is left as followup task../mach build -ddoes not report any errors./mach test-tidydoes not report any errors