-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.48.1 gives Credentials error. #6414
Comments
I am having the same issue |
What ever changes you merged onto
|
Same issue when trying to deploy in AWS CodePipeline.
|
Still facing the same issue with 1.48.1, had to restore back to 1.48.0 in BuildSpec.yml. |
Hey @ryryfasch, thanks for opening this issue and thanks everyone for chiming in. Apparently this PR broke causes the problem: #6393 It seems like all of you use CodePipeline, so my hunch is that there's something going on with the credentials in the CI / CD environment. Can anyone shed some light into the way CodePipeline handles AWS credentials to carry out the deployments? With that information we can provide a fix ASAP. Thanks! |
Serverless Error --------------------------------------- ServerlessError: AWS provider credentials not found. Learn how to set up AWS provider credentials in our docs here: http://bit.ly/aws-creds-setup. Get Support -------------------------------------------- Your Environment Information --------------------------- Had the same problem in codebuild stage in codepipeline. Serveless doesn't seem to be able to get the role associated with the codebuild instance. Went back to 1.48.0 and everything is working. |
+1 on AWS CodeBuild. Rolled back to 1.48.0 for now. Serverless Error --------------------------------------- ServerlessError: AWS provider credentials not found. Learn how to set up AWS provider credentials in our docs here: http://bit.ly/aws-creds-setup. Get Support -------------------------------------------- Your Environment Information --------------------------- |
@pmuens I believe CodeBuild sets environment variables for AWS credentials based on the configured pipeline role. The variables in question should be: I'm guessing serverless isn't falling back to these environment variables anymore when looking for credentials. |
It's also not falling back to the metadata API. That's the mech that I've used by default. I'll comment on the PR and see if I can work out what broke. |
Ok, so PR #6393 implies that you'll have a default profile and some credentials set. That's not the case, as AWS falls back to metadata API and the IAM role of the machine executing. I guess that's the case with CodePipeline too (uses IAM attached to the job to set permissions). |
Hmm. @dci-aloughran I attempted to check the creds in #6427 using |
Ahah, per https://docs.aws.amazon.com/codebuild/latest/userguide/troubleshooting.html#troubleshooting-versions CodeBuild uses |
Run into the same problem in codebuild. I think we shouldn't force to use AWS keys in order to deploy serverless apps. in codebuild, I have managed role which has the right access for deployment without using any AWS keys. |
1.48.2 is broken too. |
We are experiencing this issue on our Jenkins box as well which uses EC2 based IAM role permissions. |
This issue will likely affect any EC2/ECS based environment which rely on the metadata service to access instance profile credentials. |
This is a pretty major bug that will block a lot of CD pipelines that we have setup. Is there a timeframe of when this bug will be addressed? |
Encountered this issue today using 1.48.2. We can temporarily stick with 1.48.0 but this should be resolved as soon as possible. |
Also affecting Buildkite on 1.48.2 |
I've released 1.48.3 which should address this issue |
Excellent work. Really appreciate the dedication of maintainers. Thank you. |
1.48.3 working as expected! Thank you! Edit: Running Jenkins with Amazon Elastic Container Service Plugin |
1.48.3 Working now, thanks for the support! |
Thanks for the fix. Can confirm 1.48.3 is working in aws now! Moving forward I think we are going to lock it at this version till we test and validate. |
@curryfury-slalom never a bad idea to pin dependencies ;) |
Thank you, works on aws codebuild too |
This is a Bug Report
Description
What went wrong?
Our set up uses a serverless.yml file to deploy stacks. The pipeline were successfully building before the release of 1.48.1. I verified that this was an issue with serverless by installing 1.48.0 instead of the latest release using this command:
npm install -g serverless@1.48.0
. When I use 1.48.0 the builds pass as expected.Similar or dependent issues:
Additional Data
The text was updated successfully, but these errors were encountered: