Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce faker jar size #165

Closed
serpro69 opened this issue Oct 30, 2022 · 0 comments · Fixed by #168
Closed

Reduce faker jar size #165

serpro69 opened this issue Oct 30, 2022 · 0 comments · Fixed by #168
Labels
core 🧬 Issue related to :core module
Milestone

Comments

@serpro69
Copy link
Owner

serpro69 commented Oct 30, 2022

The final jar size of kotlin-faker library is ~20M . Looking at the jar contents, icu lib takes most of the size , with locales files and shadowed jackson being the next two.

icu was added in this commit: a556f24#diff-a6fced4b4e4a99784a2b92028b1adbc8c0ca28ff54e264b0e73727b3d4a460cf , but why is it relocated and included in the final jar? I think this can be changed and included as a regular dependency, which should reduce the jar size to 5M.

Further, using minimize function with the shadowJar might reduce the jar size even more.

@serpro69 serpro69 added the core 🧬 Issue related to :core module label Oct 30, 2022
@serpro69 serpro69 added this to the 1.13.0 milestone Oct 30, 2022
@serpro69 serpro69 linked a pull request Nov 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core 🧬 Issue related to :core module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant