Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Values with single '?' char are not always letterified #56

Closed
serpro69 opened this issue Dec 24, 2020 · 0 comments
Closed

Values with single '?' char are not always letterified #56

serpro69 opened this issue Dec 24, 2020 · 0 comments
Labels
bug 🐞 Something isn't working core 🧬 Issue related to :core module
Milestone
1.6.0

Comments

@serpro69
Copy link
Owner

The issue is in the regex:

kotlin-faker/core/src/main/kotlin/io/github/serpro69/kfaker/FakerService.kt

Line 35 in 94a8f11

private val letterRegex = Regex("""(\?\?+)[^\{\s+\p{L}+]?""")

But we have cases where single ? char should not be replaced, i.e. quotes.
@serpro69 serpro69 added bug 🐞 Something isn't working core 🧬 Issue related to :core module labels Dec 24, 2020
@serpro69 serpro69 added this to the 1.6.0 milestone Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 Something isn't working core 🧬 Issue related to :core module
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
1 participant
@serpro69