Allow non-anonymous-type destructuring when trimmed #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An old refactor pulled out structure capturing logic into a method incorrectly named
TryConvertCompilerGeneratedType; this in fact is the catch-all for non-scalar/dictionary/enumerable types without an explicitIDestructuringPolicyconfigured.The misleading name led to incorrect logic being implemented for skipping capturing of compiler-generated type properties when not supported: in this situation all structure capturing will be skipped.
This PR fixes the method name -
TryConvertStructure- and the aforementioned trimming-related logic.