Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Serilog.dll as Major.Minor.0.0 #2083

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

nblumhardt
Copy link
Member

Fixes #2074

This is essentially a commitment to strong binary backwards/forwards compatibility between all versions in a Major.Minor series.

@bartelink
Copy link
Member

FYI the PackageValidation 'tool' seems to work great for me, see jet/equinox#455
e.g. jet/FsCodec@18acc38

@nblumhardt
Copy link
Member Author

Thanks for the pointer, looks interesting. We have pretty good API compat tests currently via the approval tests, but the non-baselined validation could be interesting to add - not sure what checks are in there, but keen to explore when I have a chance.

@bartelink
Copy link
Member

It costs nothing (except some compile (but hopefully just packaging) time) to turn in on for research purposes, but I also agree that the current system aint broken ;)

@nblumhardt nblumhardt merged commit d98f7fa into serilog:dev Jul 11, 2024
1 check passed
@nblumhardt nblumhardt mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using Major.0.0.0 or Major.Minor.0.0 assembly versioning
2 participants