Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a UtcTimestamp token and a small unit test #2051

Merged
merged 7 commits into from
Apr 23, 2024

Conversation

MatthewHays
Copy link
Contributor

@MatthewHays MatthewHays commented Apr 21, 2024

Add the UtcTimestamp token to the MesageTemplateFormatter, allowing for built in support of logging timestamps in UTC in custom formats without having to use the various workarounds (expressions/custom properties etc). Also added a small unit test to show that the correct value is output, and with a custom format.

@MatthewHays MatthewHays changed the title Add a UTCTimestamp token and a small unit test Add a UtcTimestamp token and a small unit test Apr 21, 2024
Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MatthewHays!

@MatthewHays
Copy link
Contributor Author

Thanks, do I need to explicitly merge this in or perform any actions now? Also, is there an estimated date for the next 4.0.0 (non pre)release so I can start to use this?

@bartelink
Copy link
Member

No, nothing specific for you to do; It'll get merged manually (by Nick).
The minute it does get merged, there's an associated -dev build on nuget (and in general authors validate those by dogfooding).
After that, there's a promotion from dev to master that triggers the full release. (In practice, lots of consumers use the -dev releases so the actual move to a non -dev release is typically a non-event)

@MatthewHays
Copy link
Contributor Author

MatthewHays commented Apr 22, 2024

Thanks, it looks like 3.1.1 was 5 months ago, and the first dev build of 4.0.0 was 2 months ago, so hopefully a non-dev 4.0.0 build is close by. Happy to confirm the dev ver works locally, but I might get a few side eyes pushing in a dependency to a dev version into our code base :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants