-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a UtcTimestamp token and a small unit test #2051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @MatthewHays!
Thanks, do I need to explicitly merge this in or perform any actions now? Also, is there an estimated date for the next 4.0.0 (non pre)release so I can start to use this? |
No, nothing specific for you to do; It'll get merged manually (by Nick). |
Thanks, it looks like 3.1.1 was 5 months ago, and the first dev build of 4.0.0 was 2 months ago, so hopefully a non-dev 4.0.0 build is close by. Happy to confirm the dev ver works locally, but I might get a few side eyes pushing in a dependency to a dev version into our code base :) |
Add the UtcTimestamp token to the MesageTemplateFormatter, allowing for built in support of logging timestamps in UTC in custom formats without having to use the various workarounds (expressions/custom properties etc). Also added a small unit test to show that the correct value is output, and with a custom format.