Removed temporary array allocations for properties #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure it's worth (and possible) to optimize the default https://github.com/dotnet/csharplang/blob/main/proposals/params-span.md |
epeshk
force-pushed
the
properties-span
branch
from
8bce52c to
3b7311a
Compare
|
Thanks - this looks like a nice option 👍 - may take some more time to review. |
|
I think this is the way to go - looks like CI produced some failures, though. |
nblumhardt
reviewed
Oct 2, 2023
| { | ||
| if (messageTemplateParameters == null || messageTemplateParameters.Length == 0) | ||
| if (messageTemplateParameters.Length == 0) |
There was a problem hiding this comment.
May be worth including a few quick speculative tests to check that removing the == null test here is safe even when callers without strict null checking enabled call various logger methods, e.g.:
[Fact]
public void NullMessageTemplateParametersDoNotBreakBinding()
{
var log = new LoggerConfiguration().WriteTo.Sink(new CollectingSink()).CreateLogger();
log.Information("test", (object?[]?) null);
log.BindMessageTemplate("test", (object?[]?)null, out _, out _);
}?
epeshk
force-pushed
the
properties-span
branch
from
192b494 to
0b60bc6
Compare
epeshk
force-pushed
the
properties-span
branch
from
0b60bc6 to
ee6dd12
Compare
nblumhardt
approved these changes
Oct 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1779, but uses on-stack allocation instead of pooling.