Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reserved words dependency #580

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Fix reserved words dependency #580

merged 1 commit into from
Dec 9, 2021

Conversation

honzajerabek
Copy link
Contributor

reserved-words is being used in published code but it's defined as devDependency. It should be either dependency or at least peerDependency. My project doesn't use it and sequelize-auto ends with an error

Error: Cannot find module 'reserved-words'
Require stack:
- node_modules/sequelize-auto/lib/types.js
- node_modules/sequelize-auto/lib/auto-builder.js
- node_modules/sequelize-auto/lib/auto.js
- node_modules/sequelize-auto/index.js
- node_modules/sequelize-auto/bin/sequelize-auto

@JerrysShan
Copy link
Contributor

#581

@steveschmitt steveschmitt merged commit 4197141 into sequelize:master Dec 9, 2021
@steveschmitt
Copy link
Collaborator

Thanks! Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@honzajerabek @JerrysShan @steveschmitt