Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docs on S2 query by tile #326

Merged
merged 1 commit into from
Oct 31, 2019
Merged

improve docs on S2 query by tile #326

merged 1 commit into from
Oct 31, 2019

Conversation

j08lue
Copy link
Contributor

@j08lue j08lue commented Oct 24, 2019

The docs have an example on how to query for Sentinel-2 products by tile, which is a rather common use case. The explanation of a related metadata inconsistency was inaccurate and @valgur suggested a nice way of handling this issue, which I include in the docs with this change.

Closes #277
Fixes #279

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #326 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files           3        3           
  Lines         663      663           
  Branches      152      152           
=======================================
  Hits          623      623           
  Misses         26       26           
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 047190d...c779b2b. Read the comment docs.

@j08lue j08lue requested review from valgur and removed request for valgur October 24, 2019 20:11
@j08lue
Copy link
Contributor Author

j08lue commented Oct 31, 2019

I guess I can safely merge this, so we can focus on the PRs with more critical changes.

@j08lue j08lue merged commit 5ce3c82 into sentinelsat:master Oct 31, 2019
@j08lue j08lue deleted the docs-tileid branch October 31, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant