Update VCR recordings #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 95.14% 95.33% +0.18%
==========================================
Files 3 3
Lines 536 536
Branches 108 108
==========================================
+ Hits 510 511 +1
Misses 16 16
+ Partials 10 9 -1
Continue to review full report at Codecov.
|
kr-stn
approved these changes
Jun 20, 2018
| products = re.findall("^Product .+$", result.output, re.M) | ||
| # Check that all returned products are of type 'S2MSI1C' | ||
| assert len(products) > 0 | ||
| assert all("Instrument: MSI, Mode: , Satellite: Sentinel-2" in p for p in products) |
There was a problem hiding this comment.
The logic is still sound and you improved the test by asserting that all products are correct, not just the first one. Great job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated any changed recordings and fixed a single broken unit test.
@Fernerkundung Could you please check that the logic of
test_option_hierarchy()is still sound?