Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid UnboundLocalError with area wkt in CLI #164

Merged
merged 4 commits into from
Oct 12, 2017
Merged

Avoid UnboundLocalError with area wkt in CLI #164

merged 4 commits into from
Oct 12, 2017

Conversation

j08lue
Copy link
Contributor

@j08lue j08lue commented Oct 12, 2017

Fixes #155

@codecov
Copy link

codecov bot commented Oct 12, 2017

Codecov Report

Merging #164 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files           3        3           
  Lines         539      539           
  Branches      109      109           
=======================================
  Hits          515      515           
  Misses         15       15           
  Partials        9        9
Impacted Files Coverage Δ
sentinelsat/scripts/cli.py 94.18% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 862f049...1827a28. Read the comment docs.

@kr-stn
Copy link
Member

kr-stn commented Oct 12, 2017

There seem to be some leftover commits from #162. Do you mind if I squash them with the merge?

@j08lue
Copy link
Contributor Author

j08lue commented Oct 12, 2017

Do you mind if I squash them with the merge?

Please do, and tell me how you do that. 😄

@j08lue
Copy link
Contributor Author

j08lue commented Oct 12, 2017

ahh - the "Squash and merge" option on the drop-down menue here on GitHub?

@kr-stn
Copy link
Member

kr-stn commented Oct 12, 2017

Yep, that one.

Personally I find that a lot easier than pulling a PR and rebasing myself. 😉

@kr-stn kr-stn merged commit 2c59b6a into sentinelsat:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants