Fix unit test regressions #168
Conversation
The server's response for invalide queries has changed. An empty query is now returned instead of an error. SentinelDataHub/DataHubSystem#29
Unescaped quote symbols no longer cause errors, so a workaround is no longer needed.
The needed changes were all trivial and simply account for changes in the server content.
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
==========================================
- Coverage 95.53% 95.28% -0.25%
==========================================
Files 3 3
Lines 537 530 -7
Branches 108 108
==========================================
- Hits 513 505 -8
- Misses 15 16 +1
Partials 9 9
Continue to review full report at Codecov.
|
|
The first change raises a small question though. With this PR, invalid query parameters no longer raise an error but return an empty response instead. This reflects the server-side behavior. |
|
I am in favor of raising an error for invalid queries, too. The server will evolve (hopefully) and we will keep adapting our client. If the server at some point stops returning |
|
+1 on continue to raise the exception. Even though we state in our contribution guidelines, that "sentinelsat should interface the functions of DHuS where possible" I think a server side bug is clearly not a function. |
It's been a while since the VCR cassettes have been updated. So I did. This broke a bunch of them, tough. About a half of these were due to simple content changes on the server (images appearing or disappearing). The rest were caused by some minor apparent changes in the server-side query handling and required some actual code change. This includes:
xxx:yyy) no longer raise an error but they return a response with the product count set tonull, which broke our code. (Invalid query handling SentinelDataHub/DataHubSystem#29)