Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use testify #269

Merged
merged 5 commits into from
Oct 1, 2018
Merged

use testify #269

merged 5 commits into from
Oct 1, 2018

Conversation

arxdsilva
Copy link
Contributor

@arxdsilva arxdsilva commented Sep 18, 2018 •
edited
Loading

fixes #218

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 18, 2018
@arxdsilva
Copy link
Contributor Author

hi @thinkingserious , I've been adding the error messages to the testify assertions, but they seem redundant, do you think that it's best to remove them all or just keep them?

@codecov
Copy link

codecov bot commented Sep 24, 2018 •
edited
Loading

Codecov Report

Merging #269 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #269   +/-   ##
=======================================
  Coverage   70.95%   70.95%           
=======================================
  Files           3        3           
  Lines         451      451           
=======================================
  Hits          320      320           
  Misses        127      127           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cb43f4...f728210. Read the comment docs.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty labels Sep 29, 2018
@arxdsilva arxdsilva changed the title mail: add testify use testify Sep 30, 2018
@thinkingserious thinkingserious merged commit 30c7277 into sendgrid:master Oct 1, 2018
@thinkingserious
Copy link
Contributor

Hello @arxdsilva,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious added hacktoberfest status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Oct 1, 2018
@thinkingserious
Copy link
Contributor

Congrats @arxdsilva! You are first on the leaderboard: https://dx.sendgrid.com/hacktoberfest :)

@arxdsilva arxdsilva mentioned this pull request Oct 3, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace 'testing' with Testify
2 participants
@arxdsilva @thinkingserious